Speed up byteain by not parsing traditional-style input twice.
Tom Lane <tgl@sss.pgh.pa.us>
Speed up byteain by not parsing traditional-style input twice. Instead of laboriously computing the exact output length, use strlen to get an upper bound cheaply. (This is still O(N) of course, but the constant factor is a lot less.) This will typically result in overallocating the output datum, but that's of little concern since it's a short-lived allocation in just about all use-cases. A simple microbenchmark showed about 40% speedup for long input strings. While here, make some cosmetic cleanups and add a test case that covers the double-backslash code path in byteain and byteaout. Author: Steven Niu <niushiji@gmail.com> Reviewed-by: Kirill Reshke <reshkekirill@gmail.com> Reviewed-by: Stepan Neretin <slpmcf@gmail.com> Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/ca315729-140b-426e-81a6-6cd5cfe7ecc5@gmail.com
Files
| Path | Change | +/− |
|---|---|---|
| src/backend/utils/adt/bytea.c | modified | +16 −45 |
| src/test/regress/expected/strings.out | modified | +12 −0 |
| src/test/regress/sql/strings.sql | modified | +2 −0 |
Discussion
- [PATCH] avoid double scanning in function byteain 16 messages · 2025-03-26 → 2025-07-28