Horton

Suppress -Wimplicit-fallthrough warning in new LIMIT WITH TIES code.

Tom Lane <tgl@sss.pgh.pa.us>

View on postgr.es
Commit: 35cb574aa84723f4661e9fc51340130e64cb5dfc
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: 2020-04-11T19:02:44Z
Releases: 13.0 
Suppress -Wimplicit-fallthrough warning in new LIMIT WITH TIES code.

The placement of the fall-through comment in this code appears not to
work to suppress the warning in recent gcc.  Move it to the bottom of
the case group, and add an assertion that we didn't get there through
some other code path.  Also improve wording of nearby comments.

Julien Rouhaud, comment hacking by me

Discussion: https://postgr.es/m/CAOBaU_aLdPGU5wCpaowNLF-Q8328iR7mj1yJAhMOVsdLwY+sdg@mail.gmail.com

Files

PathChange+/−
src/backend/executor/nodeLimit.c modified +19 −14

Discussion