pg_upgrade: run all data type checks per connection

Daniel Gustafsson <dgustafsson@postgresql.org>

Commit: 347758b1206364e3bec5ad6cd649b4ba9fe1be7b
Author: Daniel Gustafsson <dgustafsson@postgresql.org>
Date: 2024-03-19T12:32:50Z
Releases: 17.0
pg_upgrade: run all data type checks per connection

The checks for data type usage were each connecting to all databases
in the cluster and running their query. On clusters which have a lot
of databases this can become unnecessarily expensive. This moves the
checks to run in a single connection instead to minimize setup and
teardown overhead.

Reviewed-by: Nathan Bossart <nathandbossart@gmail.com>
Reviewed-by: Justin Pryzby <pryzby@telsasoft.com>
Reviewed-by: Peter Eisentraut <peter@eisentraut.org>
Discussion: https://postgr.es/m/BB4C76F-D416-4F9F-949E-DBE950D37787@yesql.se

Files

PathChange+/−
src/bin/pg_upgrade/check.c modified +493 −256
src/bin/pg_upgrade/pg_upgrade.h modified +4 −9
src/bin/pg_upgrade/version.c modified +9 −256

Discussion

Cited messages not in the archive: BB4C76F-D416-4F9F-949E-DBE950D37787@yesql.se