Fix ruleutils.c's dumping of whole-row Vars in more contexts.

Tom Lane <tgl@sss.pgh.pa.us>

Commit: 3433a1fc76762675170c7d2455ea29e575918898
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: 2022-01-13T22:49:26Z
Releases: 10.20
Fix ruleutils.c's dumping of whole-row Vars in more contexts.

Commit 7745bc352 intended to ensure that whole-row Vars would be
printed with "::type" decoration in all contexts where plain
"var.*" notation would result in star-expansion, notably in
ROW() and VALUES() constructs.  However, it missed the case of
INSERT with a single-row VALUES, as reported by Timur Khanjanov.

Nosing around ruleutils.c, I found a second oversight: the
code for RowCompareExpr generates ROW() notation without benefit
of an actual RowExpr, and naturally it wasn't in sync :-(.
(The code for FieldStore also does this, but we don't expect that
to generate strictly parsable SQL anyway, so I left it alone.)

Back-patch to all supported branches.

Discussion: https://postgr.es/m/efaba6f9-4190-56be-8ff2-7a1674f9194f@intrans.baku.az

Files

Discussion