Fix a bunch of minor portability problems and maybe-bugs revealed by

Tom Lane <tgl@sss.pgh.pa.us>

Commit: 341b328b180e65d1fa5c8f2235cf101c8a12824f

Author: Tom Lane <tgl@sss.pgh.pa.us>

Date: 2000-03-17T02:36:41Z

Fix a bunch of minor portability problems and maybe-bugs revealed by
running gcc and HP's cc with warnings cranked way up.  Signed vs unsigned
comparisons, routines declared static and then defined not-static,
that kind of thing.  Tedious, but perhaps useful...

Files

Path	Change	+/−
src/backend/access/gist/gist.c	modified	+2 −2
src/backend/access/hash/hashinsert.c	modified	+2 −2
src/backend/access/hash/hashovfl.c	modified	+3 −3
src/backend/access/hash/hashpage.c	modified	+2 −2
src/backend/access/hash/hashsearch.c	modified	+2 −2
src/backend/access/heap/hio.c	modified	+8 −8
src/backend/access/nbtree/nbtinsert.c	modified	+4 −4
src/backend/access/nbtree/nbtsearch.c	modified	+5 −5
src/backend/access/transam/xact.c	modified	+2 −1
src/backend/catalog/heap.c	modified	+9 −9
src/backend/commands/comment.c	modified	+9 −9
src/backend/commands/vacuum.c	modified	+7 −6
src/backend/libpq/be-pqexec.c	modified	+2 −2
src/backend/libpq/hba.c	modified	+2 −2
src/backend/libpq/portalbuf.c	modified	+5 −5
src/backend/libpq/portal.c	modified	+3 −3
src/backend/nodes/outfuncs.c	modified	+3 −3
src/backend/nodes/readfuncs.c	modified	+3 −3
src/backend/optimizer/path/clausesel.c	modified	+2 −2
src/backend/optimizer/plan/subselect.c	modified	+4 −4
src/backend/parser/parse_agg.c	modified	+2 −2
src/backend/parser/parse_relation.c	modified	+2 −2
src/backend/postmaster/postmaster.c	modified	+2 −2
src/backend/storage/file/fd.c	modified	+2 −2
src/backend/storage/ipc/sinvaladt.c	modified	+3 −3
src/backend/utils/adt/ruleutils.c	modified	+4 −4
src/backend/utils/cache/relcache.c	modified	+2 −2
src/backend/utils/hash/dynahash.c	modified	+3 −3
src/backend/utils/hash/hashfn.c	modified	+2 −2
src/backend/utils/mmgr/portalmem.c	modified	+2 −2
src/backend/utils/sort/logtape.c	modified	+2 −2
src/backend/utils/sort/tuplesort.c	modified	+2 −2
src/include/access/itup.h	modified	+3 −3
src/include/access/tupmacs.h	modified	+3 −3
src/include/optimizer/subselect.h	modified	+1 −1
src/include/postgres.h	modified	+2 −2
src/include/storage/block.h	modified	+2 −2