Revert "Allow parallel workers to cope with a newly-created session user ID."
Tom Lane <tgl@sss.pgh.pa.us>
Revert "Allow parallel workers to cope with a newly-created session user ID." This reverts commit 216201027d90e99a0a2b2d2efba85dc0aac94c62. Some buildfarm animals are failing with "cannot change "client_encoding" during a parallel operation". It looks like assign_client_encoding is unhappy at being asked to roll back a client_encoding setting after a parallel worker encounters a failure. There must be more to it though: why didn't I see this during local testing? In any case, it's clear that moving the RestoreGUCState() call is not as side-effect-free as I thought. Given that the bug f5f30c22e intended to fix has gone unreported for years, it's not something that's urgent to fix; I'm not willing to risk messing with it further with only days to our next release wrap.
Files
| Path | Change | +/− |
|---|---|---|
| src/backend/access/transam/parallel.c | modified | +4 −8 |
| src/backend/commands/variable.c | modified | +2 −8 |
| src/test/regress/expected/select_parallel.out | modified | +0 −18 |
| src/test/regress/sql/select_parallel.sql | modified | +0 −9 |