postgres_fdw: Promote an Assert() to elog().

Robert Haas <rhaas@postgresql.org>

Commit: 332fdbef20b5b5f2588447793dbcc3bb9b88eb51
Author: Robert Haas <rhaas@postgresql.org>
Date: 2016-06-14T13:00:12Z
Releases: 9.6.0
postgres_fdw: Promote an Assert() to elog().

Andreas Seltenreich reports that it is possible for a PlaceHolderVar
to creep into this tlist, and I fear that even after that's fixed we
might have other, similar bugs in this area either now or in the
future.  There's a lot of action-at-a-distance here, because the
validity of this assertion depends on core planner behavior; so, let's
use elog() to make sure we catch this even in non-assert builds,
rather than just crashing.

Files

PathChange+/−
contrib/postgres_fdw/deparse.c modified +3 −1