Revert "Allow parallel workers to cope with a newly-created session user ID."

Tom Lane <tgl@sss.pgh.pa.us>

Commit: 33187ab5984fcbb4afc0999e478b3e965c4262ab
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: 2024-08-01T00:54:59Z
Releases: 16.4
Revert "Allow parallel workers to cope with a newly-created session user ID."

This reverts commit 849326e49a5dd56941eb8fb4699130c301bff303.

Some buildfarm animals are failing with "cannot change
"client_encoding" during a parallel operation".  It looks like
assign_client_encoding is unhappy at being asked to roll back a
client_encoding setting after a parallel worker encounters a
failure.  There must be more to it though: why didn't I see this
during local testing?  In any case, it's clear that moving the
RestoreGUCState() call is not as side-effect-free as I thought.
Given that the bug f5f30c22e intended to fix has gone unreported
for years, it's not something that's urgent to fix; I'm not
willing to risk messing with it further with only days to our
next release wrap.

Files