Improve the IndexVacuumInfo/IndexBulkDeleteResult API to allow somewhat sane
Tom Lane <tgl@sss.pgh.pa.us>
Improve the IndexVacuumInfo/IndexBulkDeleteResult API to allow somewhat sane behavior in cases where we don't know the heap tuple count accurately; in particular partial vacuum, but this also makes the API a bit more useful for ANALYZE. This patch adds "estimated_count" flags to both structs so that an approximate count can be flagged as such, and adjusts the logic so that approximate counts are not used for updating pg_class.reltuples. This fixes my previous complaint that VACUUM was putting ridiculous values into pg_class.reltuples for indexes. The actual impact of that bug is limited, because the planner only pays attention to reltuples for an index if the index is partial; which probably explains why beta testers hadn't noticed a degradation in plan quality from it. But it needs to be fixed. The whole thing is a bit messy and should be redesigned in future, because reltuples now has the potential to drift quite far away from reality when a long period elapses with no non-partial vacuums. But this is as good as it's going to get for 8.4.
Files
| Path | Change | +/− |
|---|---|---|
| src/backend/access/gin/ginvacuum.c | modified | +2 −1 |
| src/backend/access/gist/gistvacuum.c | modified | +3 −2 |
| src/backend/access/hash/hash.c | modified | +4 −1 |
| src/backend/access/nbtree/nbtree.c | modified | +6 −4 |
| src/backend/catalog/index.c | modified | +3 −2 |
| src/backend/commands/analyze.c | modified | +3 −2 |
| src/backend/commands/vacuum.c | modified | +23 −11 |
| src/backend/commands/vacuumlazy.c | modified | +19 −11 |
| src/backend/postmaster/pgstat.c | modified | +8 −1 |
| src/include/access/genam.h | modified | +10 −4 |