Don't fail on libpq-generated error reports in pg_amcheck.

Tom Lane <tgl@sss.pgh.pa.us>

Commit: 32a85ee46b034be7b8bf8f31b24cf6fe3684fe7f
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: 2022-06-06T15:26:57Z
Releases: 14.4
Don't fail on libpq-generated error reports in pg_amcheck.

An error PGresult generated by libpq itself, such as a report of
connection loss, won't have broken-down error fields.
should_processing_continue() blithely assumed that
PG_DIAG_SEVERITY_NONLOCALIZED would always be present, and would
dump core if it wasn't.

Per grepping to see if 6d157e7cb's mistake was repeated elsewhere.

Files

PathChange+/−
src/bin/pg_amcheck/pg_amcheck.c modified +2 −0