Horton

Avoid including commands/dbcommands.h in so many places

Álvaro Herrera <alvherre@kurilemu.de>

View on postgr.es
Commit: 325fc0ab14d11fc87da594857ffbb6636affe7c0
Author: Álvaro Herrera <alvherre@kurilemu.de>
Date: 2025-08-28T10:39:04Z
Releases: 19 (unreleased) 
Avoid including commands/dbcommands.h in so many places

This has been done historically because of get_database_name (which
since commit cb98e6fb8fd4 belongs in lsyscache.c/h, so let's move it
there) and get_database_oid (which is in the right place, but whose
declaration should appear in pg_database.h rather than dbcommands.h).
Clean this up.

Also, xlogreader.h and stringinfo.h are no longer needed by dbcommands.h
since commit f1fd515b393a, so remove them.

Author: Álvaro Herrera <alvherre@kurilemu.de>
Reviewed-by: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Reviewed-by: Michael Paquier <michael@paquier.xyz>
Discussion: https://postgr.es/m/202508191031.5ipojyuaswzt@alvherre.pgsql

Files

PathChange+/−
contrib/sepgsql/database.c modified +0 −1
contrib/sepgsql/label.c modified +0 −1
src/backend/access/heap/vacuumlazy.c modified +0 −1
src/backend/access/transam/multixact.c modified +1 −1
src/backend/access/transam/varsup.c modified +1 −1
src/backend/catalog/aclchk.c modified +0 −1
src/backend/catalog/namespace.c modified +0 −1
src/backend/catalog/objectaddress.c modified +0 −1
src/backend/catalog/pg_shdepend.c modified +1 −1
src/backend/commands/analyze.c modified +0 −1
src/backend/commands/comment.c modified +1 −1
src/backend/commands/dbcommands.c modified +1 −24
src/backend/commands/indexcmds.c modified +0 −1
src/backend/commands/publicationcmds.c modified +0 −1
src/backend/commands/schemacmds.c modified +1 −1
src/backend/commands/subscriptioncmds.c modified +0 −1
src/backend/commands/trigger.c modified +0 −1
src/backend/parser/parse_expr.c modified +0 −1
src/backend/parser/parse_target.c modified +0 −1
src/backend/postmaster/autovacuum.c modified +0 −1
src/backend/replication/logical/slotsync.c modified +0 −1
src/backend/replication/walsender.c modified +1 −1
src/backend/storage/ipc/procarray.c modified +1 −1
src/backend/utils/adt/acl.c modified +0 −1
src/backend/utils/adt/dbsize.c modified +1 −1
src/backend/utils/adt/misc.c modified +0 −1
src/backend/utils/adt/regproc.c modified +1 −1
src/backend/utils/adt/xml.c modified +0 −1
src/backend/utils/cache/lsyscache.c modified +27 −0
src/include/catalog/pg_database.h modified +1 −0
src/include/commands/dbcommands.h modified +0 −4
src/include/utils/lsyscache.h modified +1 −1
src/test/modules/worker_spi/worker_spi.c modified +1 −1

Discussion