Horton

Correct handling of fsync failures with tar mode of walmethods.c

Michael Paquier <michael@paquier.xyz>

View on postgr.es
Commit: 324076a6261756d6f5b3514ed2b2f715b656ba90
Author: Michael Paquier <michael@paquier.xyz>
Date: 2018-06-26T00:56:55Z
Releases: 10.5 
Correct handling of fsync failures with tar mode of walmethods.c

This file has been missing the fact that it needs to report back to
callers a proper failure on fsync calls.  I have spotted the one in
tar_finish() while Kuntal has spotted the one in tar_close().

Backpatch down to 10 where this code has been introduced.

Reported by: Michael Paquier, Kuntal Ghosh
Author: Michael Paquier
Reviewed-by: Kuntal Ghosh, Magnus Hagander
Discussion: https://postgr.es/m/20180625024356.GD1146@paquier.xyz

Files

PathChange+/−
src/bin/pg_basebackup/walmethods.c modified +7 −3

Discussion