Horton

Fix ALTER DEFAULT PRIVILEGES with duplicated objects

Michael Paquier <michael@paquier.xyz>

View on postgr.es
Commit: 31e0f9d76bb0196b92f6870a8e1e3e2a4e5e2b28
Author: Michael Paquier <michael@paquier.xyz>
Date: 2021-01-20T02:39:14Z
Releases: 13.2 
Fix ALTER DEFAULT PRIVILEGES with duplicated objects

Specifying duplicated objects in this command would lead to unique
constraint violations in pg_default_acl or "tuple already updated by
self" errors.  Similarly to GRANT/REVOKE, increment the command ID after
each subcommand processing to allow this case to work transparently.

A regression test is added by tweaking one of the existing queries of
privileges.sql to stress this case.

Reported-by: Andrus
Author: Michael Paquier
Reviewed-by: Álvaro Herrera
Discussion: https://postgr.es/m/ae2a7dc1-9d71-8cba-3bb9-e4cb7eb1f44e@hot.ee
Backpatch-through: 9.5

Files

PathChange+/−
src/backend/catalog/aclchk.c modified +3 −0
src/test/regress/expected/privileges.out modified +2 −1
src/test/regress/sql/privileges.sql modified +2 −1

Discussion