Fix pg_xlogdump so that it handles cross-page XLP_FIRST_IS_CONTRECORD record.

Fujii Masao <fujii@postgresql.org>

Commit: 314a25fb3ae3ae2fc6007fd39ff01da7558565a4
Author: Fujii Masao <fujii@postgresql.org>
Date: 2016-08-29T05:38:17Z
Releases: 9.4.10
Fix pg_xlogdump so that it handles cross-page XLP_FIRST_IS_CONTRECORD record.

Previously pg_xlogdump failed to dump the contents of the WAL file
if the file starts with the continuation WAL record which spans
more than one pages. Since pg_xlogdump assumed that the continuation
record always fits on a page, it could not find the valid WAL record to
start reading from in that case.

This patch changes pg_xlogdump so that it can handle a continuation
WAL record which crosses a page boundary and find the valid record
to start reading from.

Back-patch to 9.3 where pg_xlogdump was introduced.

Author: Pavan Deolasee
Reviewed-By: Michael Paquier and Craig Ringer
Discussion: CABOikdPsPByMiG6J01DKq6om2+BNkxHTPkOyqHM2a4oYwGKsqQ@mail.gmail.com

Files

PathChange+/−
src/backend/access/transam/xlogreader.c modified +64 −27