Fix possible future cache reference leak in ALTER EXTENSION ADD/DROP.
Tom Lane <tgl@sss.pgh.pa.us>
Fix possible future cache reference leak in ALTER EXTENSION ADD/DROP. recordExtObjInitPriv and removeExtObjInitPriv were sloppy about calling ReleaseSysCache. The cases cannot occur given current usage in ALTER EXTENSION ADD/DROP, since we wouldn't get here for these relkinds; but it seems wise to clean up better. In passing, extend test logic in test_pg_dump to exercise the dropped-column code paths here. Since the case is unreachable at present, there seems no great need to back-patch; hence fix HEAD only. Kyotaro Horiguchi, with test case and comment adjustments by me Discussion: https://postgr.es/m/20200417.151831.1153577605111650154.horikyota.ntt@gmail.com
Files
| Path | Change | +/− |
|---|---|---|
| src/backend/catalog/aclchk.c | modified | +29 −18 |
| src/test/modules/test_pg_dump/expected/test_pg_dump.out | modified | +2 −1 |
| src/test/modules/test_pg_dump/README | modified | +2 −0 |
| src/test/modules/test_pg_dump/sql/test_pg_dump.sql | modified | +2 −1 |
Discussion
- Possible cache reference leak by removeExtObjInitPriv 3 messages · 2020-04-17 → 2020-04-20