Fix escaping in generated recovery.conf file.

Heikki Linnakangas <heikki.linnakangas@iki.fi>

Commit: 30b5ede7157e34e77c7914b8ecfd55aa8da6edc3
Author: Heikki Linnakangas <heikki.linnakangas@iki.fi>
Date: 2013-05-20T16:41:45Z
Releases: 9.3.0
Fix escaping in generated recovery.conf file.

In the primary_conninfo line that "pg_basebackup -R" generates, single
quotes in parameter values need to be escaped into \\'; the libpq parser
requires the quotes to be escaped into \', and recovery.conf parser requires
the \ to be escaped into \\.

Also, don't quote parameter values unnecessarily, to make the connection
string prettier. Most options in a libpq connection string don't need
quoting.

Reported by Hari Babu, closer analysis by Zoltan Boszormenyi, although I
didn't use his patch.

Files

PathChange+/−
src/bin/pg_basebackup/pg_basebackup.c modified +89 −12