Horton

Fix misuse of RelOptInfo.unique_for_rels cache by SJE

Alexander Korotkov <akorotkov@postgresql.org>

View on postgr.es
Commit: 30b4955a4668887044568743debef804b14418ca
Author: Alexander Korotkov <akorotkov@postgresql.org>
Date: 2024-01-08T22:09:06Z
Releases: 17.0 
Fix misuse of RelOptInfo.unique_for_rels cache by SJE

When SJE uses RelOptInfo.unique_for_rels cache, it passes filtered quals to
innerrel_is_unique_ext().  That might lead to an invalid match to cache entries
made by previous non self-join checking calls.  Add UniqueRelInfo.self_join
flag to prevent such cases.  Also, fix that SJE should require a strict match
of outerrelids to make sure UniqueRelInfo.extra_clauses are valid.

Reported-by: Alexander Lakhin
Discussion: https://postgr.es/m/4788f781-31bd-9796-d7d6-588a751c8787%40gmail.com

Files

PathChange+/−
src/backend/optimizer/plan/analyzejoins.c modified +21 −9
src/include/nodes/pathnodes.h modified +6 −0
src/test/regress/expected/join.out modified +23 −0
src/test/regress/sql/join.sql modified +9 −0

Discussion