Remove redundant pg_unreachable() after elog(ERROR) from ExecWaitStmt()
Alexander Korotkov <akorotkov@postgresql.org>
Author:
Alexander Korotkov <akorotkov@postgresql.org>
Date: 2026-01-20T14:10:25Z
Releases:
19 (unreleased)
Remove redundant pg_unreachable() after elog(ERROR) from ExecWaitStmt() elog(ERROR) never returns. Compilers don't always understand this. So, sometimes, we have to append pg_unreachable() to keep the compiler quiet about returning from a non-void function without a value. But pg_unreachable() is redundant for ExecWaitStmt(), which is void. Reported-by: Peter Eisentraut <peter@eisentraut.org> Author: Xuneng Zhou <xunengzhou@gmail.com> Discussion: https://postgr.es/m/8d72a2b3-7423-4a15-a981-e130bf60b1a6%40eisentraut.org Discussion: https://postgr.es/m/CABPTF7UcuVD0L-X%3DjZFfeygjPaZWWkVRwtWOaJw2tcXbEN2xsA%40mail.gmail.com
Files
| Path | Change | +/− |
|---|---|---|
| src/backend/commands/wait.c | modified | +0 −3 |
Discussion
- Implement waiting for wal lsn replay: reloaded 154 messages · 2024-11-27 → 2026-07-08
Cited messages not in the archive:
8d72a2b3-7423-4a15-a981-e130bf60b1a6@eisentraut.org