Horton

Fix mismatched deallocation functions

Peter Eisentraut <peter@eisentraut.org>

View on postgr.es
Commit: 30652b356d20c1d3772137370a6a8d29575e04d1
Author: Peter Eisentraut <peter@eisentraut.org>
Date: 2026-07-01T11:50:08Z
Releases: master 
Fix mismatched deallocation functions

In fe_memutils.h, we have various allocation functions beginning with
either pg_ or p.  The pg_ functions have a matching pg_free() for
freeing memory, while the p functions use pfree().  In some cases, we
were allocating memory with one set of functions while using the wrong
deallocation functions.  This creates a tiny bit of mental overhead
when reading code.  Matching up allocation and deallocation functions
makes it easier to analyze memory handling in a code path.

Author: Tristan Partin <tristan@partin.io>
Reviewed-by: Zsolt Parragi <zsolt.parragi@percona.com>
Discussion: https://www.postgresql.org/message-id/flat/DIBZE2B6SVF2.28R3EQTYJSWIG@partin.io

Files

PathChange+/−
contrib/oid2name/oid2name.c modified +3 −3
src/bin/initdb/initdb.c modified +7 −7
src/bin/pg_basebackup/pg_basebackup.c modified +2 −2
src/bin/pg_basebackup/pg_createsubscriber.c modified +6 −6
src/bin/pg_basebackup/streamutil.c modified +4 −4
src/bin/pgbench/pgbench.c modified +2 −2
src/bin/pg_combinebackup/load_manifest.c modified +1 −1
src/bin/pg_combinebackup/pg_combinebackup.c modified +1 −1
src/bin/pg_combinebackup/reconstruct.c modified +4 −4
src/bin/pg_ctl/pg_ctl.c modified +5 −5
src/bin/pg_dump/compress_gzip.c modified +4 −4
src/bin/pg_dump/compress_lz4.c modified +1 −1
src/bin/pg_dump/compress_none.c modified +1 −1
src/bin/pg_dump/connectdb.c modified +6 −6
src/bin/pg_dump/dumputils.c modified +2 −2
src/bin/pg_dump/parallel.c modified +1 −1
src/bin/pg_dump/pg_backup_archiver.c modified +14 −14
src/bin/pg_dump/pg_backup_custom.c modified +2 −2
src/bin/pg_dump/pg_backup_db.c modified +2 −2
src/bin/pg_dump/pg_backup_directory.c modified +1 −1
src/bin/pg_dump/pg_backup_tar.c modified +3 −3
src/bin/pg_dump/pg_dumpall.c modified +2 −2
src/bin/pg_dump/pg_dump.c modified +64 −64
src/bin/pg_dump/pg_dump_sort.c modified +6 −6
src/bin/pg_upgrade/check.c modified +4 −4
src/bin/pg_upgrade/function.c modified +1 −1
src/bin/pg_verifybackup/pg_verifybackup.c modified +2 −2
src/bin/psql/command.c modified +5 −5
src/bin/psql/common.c modified +2 −2
src/bin/psql/describe.c modified +7 −7
src/bin/psql/help.c modified +1 −1
src/bin/psql/input.c modified +1 −1
src/bin/psql/large_obj.c modified +2 −2
src/bin/psql/mainloop.c modified +6 −6
src/bin/psql/prompt.c modified +2 −2
src/bin/psql/startup.c modified +7 −7
src/bin/psql/stringutils.c modified +3 −3
src/bin/psql/tab-complete.in.c modified +16 −16
src/bin/scripts/vacuuming.c modified +1 −1
src/common/logging.c modified +1 −1
src/fe_utils/print.c modified +20 −20
src/interfaces/ecpg/test/pg_regress_ecpg.c modified +1 −1
src/test/isolation/isolation_main.c modified +1 −1
src/test/isolation/isolationtester.c modified +5 −5
src/test/modules/libpq_pipeline/libpq_pipeline.c modified +4 −4
src/test/regress/pg_regress.c modified +3 −3
src/test/regress/pg_regress_main.c modified +1 −1

Discussion