Rewriter and planner should use only resno, not resname, to identify
Tom Lane <tgl@sss.pgh.pa.us>
Rewriter and planner should use only resno, not resname, to identify target columns in INSERT and UPDATE targetlists. Don't rely on resname to be accurate in ruleutils, either. This fixes bug reported by Donald Fraser, in which renaming a column referenced in a rule did not work very well.
Files
| Path | Change | +/− |
|---|---|---|
| src/backend/access/common/tupdesc.c | modified | +7 −9 |
| src/backend/catalog/dependency.c | modified | +3 −3 |
| src/backend/nodes/print.c | modified | +3 −2 |
| src/backend/optimizer/prep/preptlist.c | modified | +1 −3 |
| src/backend/optimizer/prep/prepunion.c | modified | +14 −7 |
| src/backend/parser/analyze.c | modified | +8 −5 |
| src/backend/parser/parse_relation.c | modified | +2 −10 |
| src/backend/parser/parse_target.c | modified | +11 −6 |
| src/backend/rewrite/rewriteHandler.c | modified | +11 −11 |
| src/backend/utils/adt/ruleutils.c | modified | +28 −40 |
| src/backend/utils/cache/lsyscache.c | modified | +21 −4 |
| src/backend/utils/misc/guc.c | modified | +3 −3 |
| src/include/access/tupdesc.h | modified | +2 −2 |
| src/include/nodes/primnodes.h | modified | +29 −10 |
| src/include/utils/lsyscache.h | modified | +2 −1 |