Horton

Fix some incorrectness in upgrade_adapt.sql on query for WITH OIDS

Michael Paquier <michael@paquier.xyz>

View on postgr.es
Commit: 3022cb14339656be2afeee72150dcc5725838398
Author: Michael Paquier <michael@paquier.xyz>
Date: 2022-12-23T02:26:49Z
Releases: 16.0 
Fix some incorrectness in upgrade_adapt.sql on query for WITH OIDS

The query used to disable WITH OIDS in all the relations making use of
it was checking for materialized views, but this is not a supported
operation.  On the contrary, this needs to be done on foreign tables.

While on it, use quote_ident() in the ALTER TABLE strings built on the
relation name.

Author: Anton A. Melnikov, Michael Paquier
Discussion: https://postgr.es/m/49f389ba-95ce-8a9b-09ae-f60650c0e7c7@inbox.ru
Backpatch-through: 12

Files

PathChange+/−
src/bin/pg_upgrade/upgrade_adapt.sql modified +2 −2

Discussion