Improve server code to read files as part of a base backup.
Robert Haas <rhaas@postgresql.org>
Improve server code to read files as part of a base backup. Don't use fread(), since that doesn't necessarily set errno. We could use read() instead, but it's even better to use pg_pread(), which allows us to avoid some extra calls to seek to the desired location in the file. Also, advertise a wait event while reading from a file, as we do for most other places where we're reading data from files. Patch by me, reviewed by Hamid Akhtar. Discussion: http://postgr.es/m/CA+TgmobBw-3573vMosGj06r72ajHsYeKtksT_oTxH8XvTL7DxA@mail.gmail.com
Files
| Path | Change | +/− |
|---|---|---|
| doc/src/sgml/monitoring.sgml | modified | +4 −0 |
| src/backend/postmaster/pgstat.c | modified | +3 −0 |
| src/backend/replication/basebackup.c | modified | +77 −66 |
| src/include/pgstat.h | modified | +2 −1 |
Documentation touched
Discussion
- improving basebackup.c's file-reading code 5 messages · 2020-04-27 → 2020-06-25