Remove pg_dump/parallel.c's useless "aborting" flag.

Tom Lane <tgl@sss.pgh.pa.us>

Commit: 2ee6bf59e51b4a9f86ef41832ae7fa92d427311b
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: 2016-05-29T17:00:09Z
Releases: 9.4.9
Remove pg_dump/parallel.c's useless "aborting" flag.

This was effectively dead code, since the places that tested it could not
be reached after we entered the on-exit-cleanup routine that would set it.
It seems to have been a leftover from a design in which error abort would
try to send fresh commands to the workers --- a design which could never
have worked reliably, of course.  Since the flag is not cross-platform, it
complicates reasoning about the code's behavior, which we could do without.

Although this is effectively just cosmetic, back-patch anyway, because
there are some actual bugs in the vicinity of this behavior.

Discussion: <15583.1464462418@sss.pgh.pa.us>

Files

PathChange+/−
src/bin/pg_dump/parallel.c modified +6 −28