Qualify table usage in dumpTable() and use regclass

Stephen Frost <sfrost@snowman.net>

Commit: 2e8b4bf80473d0e4a4254b417424e79195a9ce6a
Author: Stephen Frost <sfrost@snowman.net>
Date: 2016-05-25T00:10:16Z
Releases: 9.6.0
Qualify table usage in dumpTable() and use regclass

All of the other tables used in the query in dumpTable(), which is
collecting column-level ACLs, are qualified, so we should be qualifying
the pg_init_privs, the related sub-select against pg_class and the
other queries added by the pg_dump catalog ACLs work.

Also, use ::regclass (or ::pg_catalog.regclass, where appropriate)
instead of using a poorly constructed query to get the OID for various
catalog tables.

Issues identified by Noah and Alvaro, patch by me.

Files

PathChange+/−
src/bin/pg_dump/dumputils.c modified +12 −12
src/bin/pg_dump/pg_dump.c modified +34 −33
src/test/modules/test_pg_dump/t/001_base.pl modified +4 −4