DROP AGGREGATE and COMMENT ON AGGREGATE now accept the expected syntax
Tom Lane <tgl@sss.pgh.pa.us>
DROP AGGREGATE and COMMENT ON AGGREGATE now accept the expected syntax 'aggname (aggtype)'. The old syntax 'aggname aggtype' is still accepted for backwards compatibility. Fix pg_dump, which was actually broken for most cases of user-defined aggregates. Clean up error messages associated with these commands.
Files
| Path | Change | +/− |
|---|---|---|
| doc/src/sgml/ref/comment.sgml | modified | +6 −7 |
| doc/src/sgml/ref/drop_aggregate.sgml | modified | +4 −4 |
| src/backend/commands/comment.c | modified | +9 −14 |
| src/backend/commands/remove.c | modified | +12 −27 |
| src/backend/parser/analyze.c | modified | +5 −3 |
| src/backend/parser/gram.y | modified | +34 −31 |
| src/bin/pg_dump/common.c | modified | +4 −11 |
| src/bin/pg_dump/pg_dump.c | modified | +9 −6 |
| src/bin/pg_dump/pg_dump.h | modified | +2 −1 |
| src/interfaces/ecpg/preproc/preproc.y | modified | +26 −27 |
| src/test/regress/expected/errors.out | modified | +9 −9 |
| src/test/regress/sql/drop.sql | modified | +3 −3 |
| src/test/regress/sql/errors.sql | modified | +8 −8 |
| src/tutorial/complex.source | modified | +2 −2 |