Don't let libpq PGEVT_CONNRESET callbacks break a PGconn.

Tom Lane <tgl@sss.pgh.pa.us>

Commit: 2e372869aa38a9d6e4552c192da4454b17e01e38
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: 2022-02-18T16:43:04Z
Releases: 15.0
Don't let libpq PGEVT_CONNRESET callbacks break a PGconn.

As currently implemented, failure of a PGEVT_CONNRESET callback
forces the PGconn into the CONNECTION_BAD state (without closing
the socket, which is inconsistent with other failure paths), and
prevents later callbacks from being called.  This seems highly
questionable, and indeed is questioned by comments in the source.

Instead, let's just ignore the result value of PGEVT_CONNRESET
calls.  Like the preceding commit, this converts event callbacks
into "pure observers" that cannot affect libpq's processing logic.

Discussion: https://postgr.es/m/3185105.1644960083@sss.pgh.pa.us

Files

PathChange+/−
doc/src/sgml/libpq.sgml modified +5 −6
src/interfaces/libpq/fe-connect.c modified +6 −22

Documentation touched

Discussion