Minor fixes to improve regex debugging code.
Tom Lane <tgl@sss.pgh.pa.us>
Minor fixes to improve regex debugging code. When REG_DEBUG is defined, ensure that an un-filled "struct cnfa" is all-zeroes, not just that it has nstates == 0. This is mainly so that looking at "struct subre" structs in gdb doesn't distract one with a lot of garbage fields during regex compilation. Adjust some places that print debug output to have suitable fflush calls afterwards. In passing, correct an erroneous ancient comment: the concatenation subre-s created by parsebranch() have op == '.' not ','. Noted while fooling around with some regex performance improvements.
Files
| Path | Change | +/− |
|---|---|---|
| src/backend/regex/regc_nfa.c | modified | +3 −3 |
| src/backend/regex/regcomp.c | modified | +4 −1 |
| src/include/regex/regguts.h | modified | +8 −0 |