Rename shadowed local variables

David Rowley <drowley@postgresql.org>

Commit: 2d0bbedda7c4fbf7092c39b0c06b56cb238e15d7

Author: David Rowley <drowley@postgresql.org>

Date: 2022-10-05T08:01:41Z

Rename shadowed local variables

In a similar effort to f01592f91, here we mostly rename shadowed local
variables to remove the warnings produced when compiling with
-Wshadow=compatible-local.

This fixes 63 warnings and leaves just 5.

Author: Justin Pryzby, David Rowley
Reviewed-by: Justin Pryzby
Discussion https://postgr.es/m/20220817145434.GC26426%40telsasoft.com

Files

Path	Change	+/−
src/backend/access/brin/brin_minmax_multi.c	modified	+4 −4
src/backend/access/gin/ginget.c	modified	+3 −3
src/backend/access/heap/heapam.c	modified	+9 −9
src/backend/access/transam/clog.c	modified	+15 −15
src/backend/backup/basebackup.c	modified	+4 −4
src/backend/catalog/heap.c	modified	+8 −8
src/backend/catalog/namespace.c	modified	+4 −8
src/backend/commands/publicationcmds.c	modified	+3 −3
src/backend/commands/tablecmds.c	modified	+11 −11
src/backend/commands/trigger.c	modified	+2 −2
src/backend/executor/nodeAgg.c	modified	+4 −7
src/backend/executor/spi.c	modified	+13 −13
src/backend/optimizer/path/costsize.c	modified	+2 −2
src/backend/optimizer/path/indxpath.c	modified	+3 −3
src/backend/optimizer/path/tidpath.c	modified	+3 −3
src/backend/optimizer/plan/planner.c	modified	+7 −5
src/backend/optimizer/prep/prepunion.c	modified	+3 −2
src/backend/optimizer/util/clauses.c	modified	+5 −5
src/backend/optimizer/util/paramassign.c	modified	+8 −8
src/backend/parser/parse_clause.c	modified	+3 −3
src/backend/partitioning/partbounds.c	modified	+3 −3
src/backend/partitioning/partprune.c	modified	+2 −3
src/backend/replication/logical/reorderbuffer.c	modified	+5 −5
src/backend/replication/walreceiver.c	modified	+3 −3
src/backend/statistics/dependencies.c	modified	+3 −4
src/backend/storage/lmgr/lock.c	modified	+5 −5
src/backend/storage/lmgr/proc.c	modified	+14 −13
src/backend/tsearch/ts_typanalyze.c	modified	+4 −4
src/backend/utils/adt/array_typanalyze.c	modified	+3 −3
src/backend/utils/adt/datetime.c	modified	+26 −26
src/backend/utils/adt/numutils.c	modified	+3 −3
src/backend/utils/adt/partitionfuncs.c	modified	+2 −2
src/backend/utils/adt/ruleutils.c	modified	+2 −2
src/bin/psql/command.c	modified	+7 −7
src/include/lib/simplehash.h	modified	+4 −4
src/interfaces/ecpg/ecpglib/execute.c	modified	+3 −3
src/interfaces/ecpg/ecpglib/misc.c	modified	+1 −1
src/interfaces/ecpg/pgtypeslib/dt_common.c	modified	+13 −13
src/pl/plpgsql/src/pl_funcs.c	modified	+3 −4