Horton

BRIN: mask BRIN_EVACUATE_PAGE for WAL consistency checking

Alvaro Herrera <alvherre@alvh.no-ip.org>

View on postgr.es
Commit: 2cff3025906c657297ef7bf323fa715f81d20038
Author: Alvaro Herrera <alvherre@alvh.no-ip.org>
Date: 2022-08-05T16:00:17Z
Releases: 15.0 
BRIN: mask BRIN_EVACUATE_PAGE for WAL consistency checking

That bit is unlogged and therefore it's wrong to consider it in WAL page
comparison.

Add a test that tickles the case, as branch testing technology allows.

This has been a problem ever since wal consistency checking was
introduced (commit a507b86900f6 for pg10), so backpatch to all supported
branches.

Author: 王海洋 (Haiyang Wang) <wanghaiyang.001@bytedance.com>
Reviewed-by: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Discussion: https://postgr.es/m/CACciXAD2UvLMOhc4jX9VvOKt7DtYLr3OYRBhvOZ-jRxtzc_7Jg@mail.gmail.com
Discussion: https://postgr.es/m/CACciXADOfErX9Bx0nzE_SkdfXr6Bbpo5R=v_B6MUTEYW4ya+cg@mail.gmail.com

Files

PathChange+/−
src/backend/access/brin/brin_pageops.c modified +6 −1
src/backend/access/brin/brin_xlog.c modified +6 −0
src/test/modules/brin/Makefile modified +1 −1
src/test/modules/brin/t/02_wal_consistency.pl added +75 −0

Discussion