Horton

Change tupledesc->attrs[n] to TupleDescAttr(tupledesc, n).

Andres Freund <andres@anarazel.de>

View on postgr.es
Commit: 2cd70845240087da205695baedab6412342d1dbe
Author: Andres Freund <andres@anarazel.de>
Date: 2017-08-20T18:19:07Z
Releases: 11.0 
Change tupledesc->attrs[n] to TupleDescAttr(tupledesc, n).

This is a mechanical change in preparation for a later commit that
will change the layout of TupleDesc.  Introducing a macro to abstract
the details of where attributes are stored will allow us to change
that in separate step and revise it in future.

Author: Thomas Munro, editorialized by Andres Freund
Reviewed-By: Andres Freund
Discussion: https://postgr.es/m/CAEepm=0ZtQ-SpsgCyzzYpsXS6e=kZWqk3g5Ygn3MDV7A8dabUA@mail.gmail.com

Files

PathChange+/−
contrib/dblink/dblink.c modified +20 −11
contrib/file_fdw/file_fdw.c modified +3 −3
contrib/hstore/hstore_io.c modified +12 −10
contrib/pageinspect/heapfuncs.c modified +4 −4
contrib/pageinspect/rawpage.c modified +1 −1
contrib/postgres_fdw/deparse.c modified +3 −3
contrib/postgres_fdw/postgres_fdw.c modified +6 −4
contrib/spi/timetravel.c modified +1 −1
contrib/tablefunc/tablefunc.c modified +22 −20
contrib/tcn/tcn.c modified +2 −1
contrib/test_decoding/test_decoding.c modified +1 −1
src/backend/access/brin/brin.c modified +6 −4
src/backend/access/brin/brin_inclusion.c modified +3 −3
src/backend/access/brin/brin_minmax.c modified +3 −3
src/backend/access/brin/brin_tuple.c modified +1 −1
src/backend/access/common/heaptuple.c modified +48 −47
src/backend/access/common/indextuple.c modified +31 −27
src/backend/access/common/printsimple.c modified +2 −2
src/backend/access/common/printtup.c modified +11 −11
src/backend/access/common/tupconvert.c modified +29 −18
src/backend/access/common/tupdesc.c modified +23 −17
src/backend/access/gin/ginbulk.c modified +2 −1
src/backend/access/gin/ginget.c modified +1 −1
src/backend/access/gin/ginutil.c modified +8 −6
src/backend/access/gist/gistbuild.c modified +2 −2
src/backend/access/heap/heapam.c modified +4 −4
src/backend/access/heap/tuptoaster.c modified +18 −20
src/backend/access/spgist/spgutils.c modified +1 −1
src/backend/bootstrap/bootstrap.c modified +4 −4
src/backend/catalog/heap.c modified +13 −11
src/backend/catalog/index.c modified +9 −6
src/backend/catalog/toasting.c modified +12 −12
src/backend/commands/analyze.c modified +1 −1
src/backend/commands/cluster.c modified +1 −1
src/backend/commands/copy.c modified +30 −26
src/backend/commands/createas.c modified +1 −1
src/backend/commands/indexcmds.c modified +2 −2
src/backend/commands/matview.c modified +2 −1
src/backend/commands/tablecmds.c modified +36 −21
src/backend/commands/typecmds.c modified +5 −3
src/backend/commands/view.c modified +2 −2
src/backend/executor/execExpr.c modified +5 −6
src/backend/executor/execExprInterp.c modified +7 −7
src/backend/executor/execJunk.c modified +1 −1
src/backend/executor/execMain.c modified +10 −8
src/backend/executor/execReplication.c modified +1 −1
src/backend/executor/execScan.c modified +1 −1
src/backend/executor/execSRF.c modified +2 −2
src/backend/executor/execTuples.c modified +8 −5
src/backend/executor/execUtils.c modified +4 −2
src/backend/executor/functions.c modified +2 −2
src/backend/executor/nodeAgg.c modified +5 −1
src/backend/executor/nodeModifyTable.c modified +2 −1
src/backend/executor/nodeSubplan.c modified +2 −2
src/backend/executor/nodeTableFuncscan.c modified +9 −6
src/backend/executor/nodeValuesscan.c modified +3 −3
src/backend/executor/spi.c modified +8 −6
src/backend/executor/tqueue.c modified +2 −2
src/backend/executor/tstoreReceiver.c modified +6 −7
src/backend/optimizer/prep/preptlist.c modified +1 −1
src/backend/optimizer/prep/prepunion.c modified +3 −3
src/backend/optimizer/util/clauses.c modified +1 −1
src/backend/optimizer/util/plancat.c modified +5 −4
src/backend/parser/analyze.c modified +1 −1
src/backend/parser/parse_coerce.c modified +5 −4
src/backend/parser/parse_func.c modified +1 −1
src/backend/parser/parse_relation.c modified +16 −16
src/backend/parser/parse_target.c modified +8 −6
src/backend/parser/parse_utilcmd.c modified +9 −6
src/backend/replication/logical/proto.c modified +4 −4
src/backend/replication/logical/relation.c modified +3 −2
src/backend/replication/logical/reorderbuffer.c modified +1 −1
src/backend/replication/logical/worker.c modified +3 −3
src/backend/replication/pgoutput/pgoutput.c modified +1 −1
src/backend/rewrite/rewriteDefine.c modified +1 −1
src/backend/rewrite/rewriteHandler.c modified +4 −4
src/backend/utils/adt/jsonb.c modified +4 −4
src/backend/utils/adt/json.c modified +4 −4
src/backend/utils/adt/jsonfuncs.c modified +1 −1
src/backend/utils/adt/orderedsetaggs.c modified +4 −2
src/backend/utils/adt/rowtypes.c modified +75 −54
src/backend/utils/adt/ruleutils.c modified +9 −7
src/backend/utils/adt/tid.c modified +4 −2
src/backend/utils/adt/xml.c modified +9 −6
src/backend/utils/cache/catcache.c modified +3 −2
src/backend/utils/cache/relcache.c modified +32 −23
src/backend/utils/cache/typcache.c modified +4 −3
src/backend/utils/fmgr/funcapi.c modified +9 −6
src/backend/utils/misc/pg_config.c modified +2 −2
src/include/access/htup_details.h modified +3 −3
src/include/access/itup.h modified +3 −3
src/include/access/tupdesc.h modified +2 −0
src/pl/plperl/plperl.c modified +14 −12
src/pl/plpgsql/src/pl_comp.c modified +1 −1
src/pl/plpgsql/src/pl_exec.c modified +34 −16
src/pl/plpython/plpy_exec.c modified +4 −2
src/pl/plpython/plpy_resultobject.c modified +15 −3
src/pl/plpython/plpy_typeio.c modified +22 −19
src/pl/tcl/pltcl.c modified +14 −9
src/test/regress/regress.c modified +2 −2

Discussion