Horton

Revert "Logical decoding of sequences"

Tomas Vondra <tomas.vondra@postgresql.org>

View on postgr.es
Commit: 2c7ea57e56ca5f668c32d4266e0a3e45b455bef5
Author: Tomas Vondra <tomas.vondra@postgresql.org>
Date: 2022-04-07T18:06:36Z
Releases: 15.0 
Revert "Logical decoding of sequences"

This reverts a sequence of commits, implementing features related to
logical decoding and replication of sequences:

 - 0da92dc530c9251735fc70b20cd004d9630a1266
 - 80901b32913ffa59bf157a4d88284b2b3a7511d9
 - b779d7d8fdae088d70da5ed9fcd8205035676df3
 - d5ed9da41d96988d905b49bebb273a9b2d6e2915
 - a180c2b34de0989269fdb819bff241a249bf5380
 - 75b1521dae1ff1fde17fda2e30e591f2e5d64b6a
 - 2d2232933b02d9396113662e44dca5f120d6830e
 - 002c9dd97a0c874fd1693a570383e2dd38cd40d5
 - 05843b1aa49df2ecc9b97c693b755bd1b6f856a9

The implementation has issues, mostly due to combining transactional and
non-transactional behavior of sequences. It's not clear how this could
be fixed, but it'll require reworking significant part of the patch.

Discussion: https://postgr.es/m/95345a19-d508-63d1-860a-f5c2f41e8d40@enterprisedb.com

Files

PathChange+/−
contrib/test_decoding/expected/ddl.out modified +19 −19
contrib/test_decoding/expected/decoding_into_rel.out modified +5 −5
contrib/test_decoding/expected/decoding_in_xact.out modified +2 −2
contrib/test_decoding/expected/mxact.out modified +4 −4
contrib/test_decoding/expected/ondisk_startup.out modified +2 −2
contrib/test_decoding/expected/replorigin.out modified +6 −6
contrib/test_decoding/expected/rewrite.out modified +3 −3
contrib/test_decoding/expected/sequence.out deleted +0 −325
contrib/test_decoding/expected/slot.out modified +4 −4
contrib/test_decoding/expected/toast.out modified +5 −5
contrib/test_decoding/expected/truncate.out modified +1 −1
contrib/test_decoding/Makefile modified +1 −2
contrib/test_decoding/specs/mxact.spec modified +1 −1
contrib/test_decoding/specs/ondisk_startup.spec modified +1 −1
contrib/test_decoding/sql/ddl.sql modified +19 −19
contrib/test_decoding/sql/decoding_into_rel.sql modified +5 −5
contrib/test_decoding/sql/decoding_in_xact.sql modified +2 −2
contrib/test_decoding/sql/replorigin.sql modified +6 −6
contrib/test_decoding/sql/rewrite.sql modified +3 −3
contrib/test_decoding/sql/sequence.sql deleted +0 −119
contrib/test_decoding/sql/slot.sql modified +4 −4
contrib/test_decoding/sql/toast.sql modified +5 −5
contrib/test_decoding/sql/truncate.sql modified +1 −1
contrib/test_decoding/test_decoding.c modified +0 −87
doc/src/sgml/catalogs.sgml modified +0 −81
doc/src/sgml/logicaldecoding.sgml modified +5 −60
doc/src/sgml/protocol.sgml modified +0 −119
doc/src/sgml/ref/alter_publication.sgml modified +7 −18
doc/src/sgml/ref/alter_subscription.sgml modified +4 −4
doc/src/sgml/ref/create_publication.sgml modified +15 −36
src/backend/catalog/objectaddress.c modified +11 −33
src/backend/catalog/pg_publication.c modified +29 −299
src/backend/catalog/system_views.sql modified +0 −10
src/backend/commands/publicationcmds.c modified +74 −361
src/backend/commands/sequence.c modified +0 −186
src/backend/commands/subscriptioncmds.c modified +13 −88
src/backend/commands/tablecmds.c modified +1 −26
src/backend/executor/execReplication.c modified +1 −3
src/backend/nodes/copyfuncs.c modified +2 −2
src/backend/nodes/equalfuncs.c modified +2 −2
src/backend/parser/gram.y modified +14 −65
src/backend/replication/logical/decode.c modified +0 −131
src/backend/replication/logical/logical.c modified +0 −88
src/backend/replication/logical/proto.c modified +0 −52
src/backend/replication/logical/reorderbuffer.c modified +0 −405
src/backend/replication/logical/tablesync.c modified +4 −105
src/backend/replication/logical/worker.c modified +0 −56
src/backend/replication/pgoutput/pgoutput.c modified +6 −88
src/backend/utils/cache/relcache.c modified +3 −25
src/backend/utils/cache/syscache.c modified +3 −3
src/bin/pg_dump/pg_dump.c modified +9 −55
src/bin/pg_dump/pg_dump.h modified +0 −3
src/bin/pg_dump/t/002_pg_dump.pl modified +4 −36
src/bin/psql/describe.c modified +75 −222
src/bin/psql/tab-complete.c modified +13 −23
src/include/access/rmgrlist.h modified +1 −1
src/include/catalog/catversion.h modified +1 −1
src/include/catalog/pg_proc.dat modified +0 −5
src/include/catalog/pg_publication.h modified +5 −22
src/include/catalog/pg_publication_namespace.h modified +1 −9
src/include/commands/sequence.h modified +0 −2
src/include/nodes/parsenodes.h modified +2 −6
src/include/replication/decode.h modified +0 −1
src/include/replication/logicalproto.h modified +0 −19
src/include/replication/output_plugin.h modified +0 −27
src/include/replication/pgoutput.h modified +0 −1
src/include/replication/reorderbuffer.h modified +1 −42
src/test/regress/expected/object_address.out modified +3 −7
src/test/regress/expected/publication.out modified +195 −848
src/test/regress/expected/rules.out modified +0 −8
src/test/regress/sql/object_address.sql modified +1 −4
src/test/regress/sql/publication.sql modified +1 −241
src/test/subscription/t/030_sequences.pl deleted +0 −202

Documentation touched

Discussion