Avoid failure when selecting a namespace node in XMLTABLE.

Tom Lane <tgl@sss.pgh.pa.us>

Commit: 2bbdf8e2e827fe80fd39a4a5e2f432f4e8ae6ca3
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: 2019-10-25T19:22:40Z
Releases: 12.1
Avoid failure when selecting a namespace node in XMLTABLE.

It appears that libxml2 doesn't bother to set the "children" field of
an XML_NAMESPACE_DECL node to null; that field just contains garbage.
In v10 and v11, this can result in a crash in XMLTABLE().  The rewrite
done in commit 251cf2e27 fixed this, somewhat accidentally, in v12.
We're not going to back-patch 251cf2e27, however.  The case apparently
doesn't have wide use, so rather than risk introducing other problems,
just add a safety check to throw an error.

Even though no bug manifests in v12/HEAD, add the relevant test case
there too, to prevent future regressions.

Chapman Flack (per private report)

Files