Don't ERROR on PreallocXlogFiles() race condition.

Noah Misch <noah@leadboat.com>

Commit: 2b3e4672f7602a6bb46a0735a1b41b635508b290
Author: Noah Misch <noah@leadboat.com>
Date: 2021-06-29T01:34:56Z
Releases: 15.0
Don't ERROR on PreallocXlogFiles() race condition.

Before a restartpoint finishes PreallocXlogFiles(), a startup process
KeepFileRestoredFromArchive() call can unlink the preallocated segment.
If a CHECKPOINT sql command had elicited the restartpoint experiencing
the race condition, that sql command failed.  Moreover, the restartpoint
omitted its log_checkpoints message and some inessential resource
reclamation.  Prevent the ERROR by skipping open() of the segment.
Since these consequences are so minor, no back-patch.

Discussion: https://postgr.es/m/20210202151416.GB3304930@rfd.leadboat.com

Files

Discussion