Remove reset of testtablespace from pg_regress on Windows
Michael Paquier <michael@paquier.xyz>
Remove reset of testtablespace from pg_regress on Windows testtablespace is an extra path used as tablespace location in the main regression test suite, computed from --outputdir as defined by the caller of pg_regress (current directory if undefined). This special handling was introduced as of f10589e to be specific to MSVC, as we let pg_regress' Makefile handle this cleanup in other environments. This moves the cleanup to the MSVC script running regression tests instead where needed: check, installcheck and upgradecheck. I have also checked this patch on MSVC with repeated runs of each target. Author: Kyotaro Horiguchi, Michael Paquier Discussion: https://postgr.es/m/20200219.142519.437573253063431435.horikyota.ntt@gmail.com
Files
| Path | Change | +/− |
|---|---|---|
| src/test/regress/pg_regress.c | modified | +0 −22 |
| src/tools/msvc/vcregress.pl | modified | +15 −2 |
Discussion
- pg_regress cleans up tablespace twice. 22 messages · 2020-02-19 → 2020-07-11