Horton

Add missing ObjectIdGetDatum() in syscache lookup calls for Oids

Michael Paquier <michael@paquier.xyz>

View on postgr.es
Commit: 2a990abd79acea4717cc8f982a28f35b6b347ddb
Author: Michael Paquier <michael@paquier.xyz>
Date: 2023-07-20T06:18:25Z
Releases: 17.0 
Add missing ObjectIdGetDatum() in syscache lookup calls for Oids

Based on how postgres.h foes the Oid <-> Datum conversion, there is no
existing bugs but let's be consistent.  17 spots have been noticed as
incorrectly passing down Oids rather than Datums.  Aleksander got one,
Zhang two and I the rest.

Author: Michael Paquier, Aleksander Alekseev, Zhang Mingli
Discussion: https://postgr.es/m/ZLUhqsqQN1MOaxdw@paquier.xyz

Files

PathChange+/−
src/backend/catalog/index.c modified +1 −1
src/backend/commands/alter.c modified +2 −1
src/backend/commands/sequence.c modified +2 −2
src/backend/commands/tablecmds.c modified +5 −4
src/backend/commands/user.c modified +1 −1
src/backend/partitioning/partbounds.c modified +1 −1
src/backend/partitioning/partdesc.c modified +1 −1
src/backend/utils/adt/acl.c modified +2 −2
src/backend/utils/adt/ruleutils.c modified +1 −1
src/backend/utils/cache/lsyscache.c modified +4 −2
src/backend/utils/cache/partcache.c modified +2 −1

Discussion