Collect built-in LWLock tranche names statically, not dynamically.

Tom Lane <tgl@sss.pgh.pa.us>

Commit: 29c3e2dd5a6aeaf1a23d7d83d665501e2dcc6955
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: 2020-05-14T15:10:31Z
Releases: 13.0
Collect built-in LWLock tranche names statically, not dynamically.

There is little point in using the LWLockRegisterTranche mechanism for
built-in tranche names.  It wastes cycles, it creates opportunities for
bugs (since failing to register a tranche name is a very hard-to-detect
problem), and the lack of any centralized list of names encourages
sloppy nonconformity in name choices.  Moreover, since we have a
centralized list of the tranches anyway in enum BuiltinTrancheIds, we're
certainly not buying any flexibility in return for these disadvantages.

Hence, nuke all the backend-internal LWLockRegisterTranche calls,
and instead provide a const array of the builtin tranche names.

(I have in mind to change a bunch of these names shortly, but this
patch is just about getting them into one place.)

Discussion: https://postgr.es/m/9056.1589419765@sss.pgh.pa.us

Files

Discussion