Enable -Wstrict-prototypes and -Wold-style-definition by default
Peter Eisentraut <peter@eisentraut.org>
Author:
Peter Eisentraut <peter@eisentraut.org>
Date: 2026-03-18T13:31:50Z
Releases:
19 (unreleased)
Enable -Wstrict-prototypes and -Wold-style-definition by default Those are available in all gcc and clang versions that support C11 and as C11 is required as of f5e0186f865c, then we can add them without capability test. Having them enabled by default avoid having to chase these manually like 11171fe1fc8, cdf4b9aff2, 0e72b9d440, 7069dbcc31, f1283ed6cc, 7b66e2c086, e95126cf04 and 9f7c527af3 have done. Also, readline headers trigger a lot of warnings with -Wstrict-prototypes, so we make use of the system_header pragma to hide the warnings. Author: Bertrand Drouvot <bertranddrouvot.pg@gmail.com> Discussion: https://postgr.es/m/13d51b20-a69c-4ac1-8546-ec4fc278064f%40eisentraut.org Discussion: https://postgr.es/m/aTFctZwWSpl2/LG5%40ip-10-97-1-34.eu-west-3.compute.internal
Files
| Path | Change | +/− |
|---|---|---|
| configure | modified | +8 −0 |
| configure.ac | modified | +8 −0 |
| meson.build | modified | +2 −0 |
| src/bin/psql/input.h | modified | +9 −0 |
Discussion
- Use func(void) for functions with no parameters 10 messages · 2025-12-03 → 2025-12-05
- Use pg_icu_unicode_version(void) instead of pg_icu_unicode_version() 10 messages · 2026-02-27 → 2026-03-09