Horton

Revert b6002a796

David Rowley <drowley@postgresql.org>

View on postgr.es
Commit: 28b3e3905c982c42fb10ee800e6f881e9742c89d
Author: David Rowley <drowley@postgresql.org>
Date: 2021-04-01T00:33:23Z
Releases: 14.0 
Revert b6002a796

This removes "Add Result Cache executor node".  It seems that something
weird is going on with the tracking of cache hits and misses as
highlighted by many buildfarm animals.  It's not yet clear what the
problem is as other parts of the plan indicate that the cache did work
correctly, it's just the hits and misses that were being reported as 0.

This is especially a bad time to have the buildfarm so broken, so
reverting before too many more animals go red.

Discussion: https://postgr.es/m/CAApHDvq_hydhfovm4=izgWs+C5HqEeRScjMbOgbpC-jRAeK3Yw@mail.gmail.com

Files

PathChange+/−
contrib/postgres_fdw/expected/postgres_fdw.out modified +10 −15
contrib/postgres_fdw/sql/postgres_fdw.sql modified +0 −2
doc/src/sgml/config.sgml modified +2 −22
src/backend/commands/explain.c modified +0 −140
src/backend/executor/execAmi.c modified +0 −5
src/backend/executor/execExpr.c modified +0 −134
src/backend/executor/execParallel.c modified +0 −18
src/backend/executor/execProcnode.c modified +0 −10
src/backend/executor/Makefile modified +0 −1
src/backend/executor/nodeResultCache.c deleted +0 −1137
src/backend/nodes/copyfuncs.c modified +0 −31
src/backend/nodes/outfuncs.c modified +0 −37
src/backend/nodes/readfuncs.c modified +0 −22
src/backend/optimizer/path/allpaths.c modified +0 −4
src/backend/optimizer/path/costsize.c modified +0 −148
src/backend/optimizer/path/joinpath.c modified +0 −214
src/backend/optimizer/plan/createplan.c modified +0 −87
src/backend/optimizer/plan/initsplan.c modified +0 −41
src/backend/optimizer/plan/setrefs.c modified +0 −9
src/backend/optimizer/plan/subselect.c modified +0 −5
src/backend/optimizer/util/pathnode.c modified +0 −71
src/backend/optimizer/util/restrictinfo.c modified +0 −3
src/backend/utils/misc/guc.c modified +0 −10
src/backend/utils/misc/postgresql.conf.sample modified +0 −1
src/include/executor/executor.h modified +0 −7
src/include/executor/nodeResultCache.h deleted +0 −31
src/include/lib/ilist.h modified +0 −19
src/include/nodes/execnodes.h modified +0 −66
src/include/nodes/nodes.h modified +0 −3
src/include/nodes/pathnodes.h modified +0 −22
src/include/nodes/plannodes.h modified +0 −21
src/include/optimizer/cost.h modified +0 −1
src/include/optimizer/pathnode.h modified +0 −7
src/test/regress/expected/aggregates.out modified +0 −2
src/test/regress/expected/join.out modified +53 −78
src/test/regress/expected/partition_prune.out modified +110 −133
src/test/regress/expected/resultcache.out deleted +0 −159
src/test/regress/expected/subselect.out modified +9 −11
src/test/regress/expected/sysviews.out modified +1 −2
src/test/regress/parallel_schedule modified +1 −1
src/test/regress/serial_schedule modified +0 −1
src/test/regress/sql/aggregates.sql modified +0 −2
src/test/regress/sql/join.sql modified +0 −2
src/test/regress/sql/partition_prune.sql modified +0 −3
src/test/regress/sql/resultcache.sql deleted +0 −85

Documentation touched

Discussion

Cited messages not in the archive: CAApHDvq_hydhfovm4=izgWs+C5HqEeRScjMbOgbpC-jRAeK3Yw@mail.gmail.com