Horton

Fix overflow danger in SampleHeapTupleVisible()

Melanie Plageman <melanieplageman@gmail.com>

View on postgr.es
Commit: 28328ec87b45725f62bed1104d99c8b3220d1675
Author: Melanie Plageman <melanieplageman@gmail.com>
Date: 2024-12-18T23:16:43Z
Releases: 18.0 
Fix overflow danger in SampleHeapTupleVisible()

68d9662be1c4b70 made HeapScanDesc->rs_ntuples unsigned but neglected to
change how it was being used in SampleHeapTupleVisible().

Return early if rs_ntuples is 0 to avoid overflowing and incorrectly
executing the loop code in SampleHeapTupleVisible().

Reported-by: Ranier Vilela
Discussion: https://postgr.es/m/CAEudQAot_xQoZyPZjpj1aBUPrPykY5mOPHGyvfe%3Djz%2BWowdA3A%40mail.gmail.com

Files

PathChange+/−
src/backend/access/heap/heapam_handler.c modified +9 −3

Discussion