Horton

Improve new wording of libpq's connection failure messages.

Tom Lane <tgl@sss.pgh.pa.us>

View on postgr.es
Commit: 27a48e5a16ff2227ddf44ee717d9bcd89d22a7aa
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: 2021-01-21T21:10:18Z
Releases: 14.0 
Improve new wording of libpq's connection failure messages.

"connection to server so-and-so failed:" seems clearer than the
previous wording "could not connect to so-and-so:" (introduced by
52a10224e), because the latter suggests a network-level connection
failure.  We're now prefixing this string to all types of connection
failures, for instance authentication failures; so we need wording
that doesn't imply a low-level error.

Per discussion with Robert Haas.

Discussion: https://postgr.es/m/CA+TgmobssJ6rS22dspWnu-oDxXevGmhMD8VcRBjmj-b9UDqRjw@mail.gmail.com

Files

PathChange+/−
src/bin/pg_dump/t/002_pg_dump.pl modified +1 −1
src/interfaces/ecpg/test/expected/connect-test5.stderr modified +2 −2
src/interfaces/ecpg/test/pg_regress_ecpg.c modified +4 −4
src/interfaces/libpq/fe-connect.c modified +16 −15

Discussion