Horton

Assert in init_toast_snapshot() that some snapshot registered or active.

Andres Freund <andres@anarazel.de>

View on postgr.es
Commit: 2776922201f751e3202a713b61d97fe4e44a8440
Author: Andres Freund <andres@anarazel.de>
Date: 2022-02-21T16:58:29Z
Releases: 15.0 
Assert in init_toast_snapshot() that some snapshot registered or active.

Commit <FIXME> fixed the bug that RemoveTempRelationsCallback() did not
push/register a snapshot. That only went unnoticed because often a valid
catalog snapshot exists and is returned by GetOldestSnapshot(). But due to
invalidation processing that is not reliable.

Thus assert in init_toast_snapshot() that there is a registered or active
snapshot, using the new HaveRegisteredOrActiveSnapshot().

Author: Andres Freund
Discussion: https://postgr.es/m/20220219180002.6tubjq7iw7m52bgd@alap3.anarazel.de

Files

PathChange+/−
src/backend/access/common/toast_internals.c modified +9 −0
src/backend/utils/time/snapmgr.c modified +26 −0
src/include/utils/snapmgr.h modified +1 −0

Discussion