createdb: compare strategy case-insensitive
Tomas Vondra <tomas.vondra@postgresql.org>
createdb: compare strategy case-insensitive When specifying the createdb strategy, the documentation suggests valid options are FILE_COPY and WAL_LOG, but the code does case-sensitive comparison and accepts only "file_copy" and "wal_log" as valid. Fixed by doing a case-insensitive comparison using pg_strcasecmp(), same as for other string parameters nearby. While at it, apply fmtId() to a nearby "locale_provider". This already did the comparison in case-insensitive way, but the value would not be double-quoted, confusing the parser and the error message. Backpatch to 15, where the strategy was introduced. Backpatch-through: 15 Reviewed-by: Tom Lane Discussion: https://postgr.es/m/90c6913a-1dd2-42b4-8365-ce3b09c39b17@enterprisedb.com
Files
| Path | Change | +/− |
|---|---|---|
| src/backend/commands/dbcommands.c | modified | +3 −3 |
| src/bin/scripts/createdb.c | modified | +1 −1 |
| src/bin/scripts/t/020_createdb.pl | modified | +10 −0 |
Discussion
- createdb compares strategy as case-sensitive 7 messages · 2024-04-20 → 2024-04-21