Code review for 64-bit-large-object patch.
Tom Lane <tgl@sss.pgh.pa.us>
Code review for 64-bit-large-object patch. Fix broken-on-bigendian-machines byte-swapping functions, add missed update of alternate regression expected file, improve error reporting, remove some unnecessary code, sync testlo64.c with current testlo.c (it seems to have been cloned from a very old copy of that), assorted cosmetic improvements.
Files
| Path | Change | +/− |
|---|---|---|
| src/backend/libpq/be-fsstubs.c | modified | +21 −39 |
| src/backend/storage/large_object/inv_api.c | modified | +52 −23 |
| src/backend/utils/errcodes.txt | modified | +0 −1 |
| src/include/catalog/pg_proc.h | modified | +1 −1 |
| src/interfaces/libpq/fe-lobj.c | modified | +33 −54 |
| src/test/examples/testlo64.c | modified | +24 −51 |
| src/test/regress/input/largeobject.source | modified | +1 −1 |
| src/test/regress/output/largeobject_1.source | modified | +82 −0 |
| src/test/regress/output/largeobject.source | modified | +1 −1 |