Horton

pgbench: Remove \cset

Alvaro Herrera <alvherre@alvh.no-ip.org>

View on postgr.es
Commit: 25ee70511ec2ccbef0ad3fe64875a4d552cdcd50
Author: Alvaro Herrera <alvherre@alvh.no-ip.org>
Date: 2019-03-25T15:16:07Z
Releases: 12.0 
pgbench: Remove \cset

Partial revert of commit 6260cc550b0e, "pgbench: add \cset and \gset
commands".

While \gset is widely considered a useful and necessary tool for user-
defined benchmarks, \cset does not have as much value, and its
implementation was considered "not to be up to project standards"
(though I, Álvaro, can't quite understand exactly how).  Therefore,
remove \cset.

Author: Fabien Coelho
Discussion: https://postgr.es/m/alpine.DEB.2.21.1903230716030.18811@lancre
Discussion: https://postgr.es/m/201901101900.mv7zduch6sad@alvherre.pgsql

Files

PathChange+/−
doc/src/sgml/ref/pgbench.sgml modified +3 −52
src/bin/pgbench/pgbench.c modified +34 −131
src/bin/pgbench/t/001_pgbench_with_server.pl modified +17 −30
src/fe_utils/psqlscan.l modified +2 −22
src/include/fe_utils/psqlscan.h modified +0 −2
src/include/fe_utils/psqlscan_int.h modified +0 −1

Documentation touched

Discussion