Revert refactoring of hex code to src/common/
Michael Paquier <michael@paquier.xyz>
Revert refactoring of hex code to src/common/ This is a combined revert of the following commits: - c3826f8, a refactoring piece that moved the hex decoding code to src/common/. This code was cleaned up by aef8948, as it originally included no overflow checks in the same way as the base64 routines in src/common/ used by SCRAM, making it unsafe for its purpose. - aef8948, a more advanced refactoring of the hex encoding/decoding code to src/common/ that added sanity checks on the result buffer for hex decoding and encoding. As reported by Hans Buschmann, those overflow checks are expensive, and it is possible to see a performance drop in the decoding/encoding of bytea or LOs the longer they are. Simple SQLs working on large bytea values show a clear difference in perf profile. - ccf4e27, a cleanup made possible by aef8948. The reverts of all those commits bring back the performance of hex decoding and encoding back to what it was in ~13. Fow now and post-beta3, this is the simplest option. Reported-by: Hans Buschmann Discussion: https://postgr.es/m/1629039545467.80333@nidsa.net Backpatch-through: 14
Files
| Path | Change | +/− |
|---|---|---|
| src/backend/replication/backup_manifest.c | modified | +12 −18 |
| src/backend/utils/adt/encode.c | modified | +102 −56 |
| src/backend/utils/adt/varlena.c | modified | +4 −11 |
| src/common/hex.c | deleted | +0 −192 |
| src/common/Makefile | modified | +0 −1 |
| src/include/common/hex.h | deleted | +0 −25 |
| src/include/common/sha2.h | modified | +4 −0 |
| src/include/utils/builtins.h | modified | +4 −0 |
| src/tools/msvc/Mkvcbuild.pm | modified | +1 −1 |
Discussion
- PG14: Avoid checking output-buffer-length for every encoded byte during pg_hex_encode 13 messages · 2021-08-15 → 2021-08-19