Add pg_analyze_and_rewrite_varparams()
Peter Eisentraut <peter@eisentraut.org>
Add pg_analyze_and_rewrite_varparams() This new function extracts common code from PrepareQuery() and exec_parse_message(). It is then exactly analogous to the existing pg_analyze_and_rewrite_fixedparams() and pg_analyze_and_rewrite_withcb(). To unify these two code paths, this makes PrepareQuery() now subject to log_parser_stats. Also, both paths now invoke TRACE_POSTGRESQL_QUERY_REWRITE_START(). PrepareQuery() no longer checks whether a utility statement was specified. The grammar doesn't allow that anyway, and exec_parse_message() supports it, so restricting it doesn't seem necessary. This also adds QueryEnvironment support to the *varparams functions, for consistency with its cousins, even though it is not used right now. Reviewed-by: Nathan Bossart <bossartn@amazon.com> Discussion: https://www.postgresql.org/message-id/flat/c67ce276-52b4-0239-dc0e-39875bf81840@enterprisedb.com
Files
| Path | Change | +/− |
|---|---|---|
| src/backend/commands/prepare.c | modified | +4 −39 |
| src/backend/parser/analyze.c | modified | +4 −1 |
| src/backend/tcop/postgres.c | modified | +64 −31 |
| src/include/parser/analyze.h | modified | +1 −1 |
| src/include/tcop/tcopprot.h | modified | +5 −0 |
Discussion
- parse/analyze API refactoring 6 messages · 2021-12-28 → 2022-03-09