Add pg_analyze_and_rewrite_varparams()

Peter Eisentraut <peter@eisentraut.org>

Commit: 25751f54b8e02a8fff62e9dbdbc9f2efbb4e8dc1
Author: Peter Eisentraut <peter@eisentraut.org>
Date: 2022-03-07T07:13:30Z
Releases: 15.0
Add pg_analyze_and_rewrite_varparams()

This new function extracts common code from PrepareQuery() and
exec_parse_message().  It is then exactly analogous to the existing
pg_analyze_and_rewrite_fixedparams() and
pg_analyze_and_rewrite_withcb().

To unify these two code paths, this makes PrepareQuery() now subject
to log_parser_stats.  Also, both paths now invoke
TRACE_POSTGRESQL_QUERY_REWRITE_START().  PrepareQuery() no longer
checks whether a utility statement was specified.  The grammar doesn't
allow that anyway, and exec_parse_message() supports it, so
restricting it doesn't seem necessary.

This also adds QueryEnvironment support to the *varparams functions,
for consistency with its cousins, even though it is not used right
now.

Reviewed-by: Nathan Bossart <bossartn@amazon.com>
Discussion: https://www.postgresql.org/message-id/flat/c67ce276-52b4-0239-dc0e-39875bf81840@enterprisedb.com

Files

PathChange+/−
src/backend/commands/prepare.c modified +4 −39
src/backend/parser/analyze.c modified +4 −1
src/backend/tcop/postgres.c modified +64 −31
src/include/parser/analyze.h modified +1 −1
src/include/tcop/tcopprot.h modified +5 −0

Discussion