Un-break whole-row Vars referencing domain-over-composite types.
Tom Lane <tgl@sss.pgh.pa.us>
Un-break whole-row Vars referencing domain-over-composite types. In commit ec62cb0aa, I foolishly replaced ExecEvalWholeRowVar's lookup_rowtype_tupdesc_domain call with just lookup_rowtype_tupdesc, because I didn't see how a domain could be involved there, and there were no regression test cases to jog my memory. But the existing code was correct, so revert that change and add a test case showing why it's necessary. (Note: per comment in struct DatumTupleFields, it is correct to produce an output tuple that's labeled with the base composite type, not the domain; hence just blindly looking through the domain is correct here.) Per bug #17515 from Dan Kubb. Back-patch to v11 where domains over composites became a thing. Discussion: https://postgr.es/m/17515-a24737438363aca0@postgresql.org
Files
| Path | Change | +/− |
|---|---|---|
| src/backend/executor/execExprInterp.c | modified | +5 −1 |
| src/test/regress/expected/domain.out | modified | +23 −0 |
| src/test/regress/sql/domain.sql | modified | +9 −0 |
Discussion
- BUG #17515: Change in behaviour of a composite type within a domain 2 messages · 2022-06-09 → 2022-06-10