Further improvements to c8f621c43.

Andres Freund <andres@anarazel.de>

Commit: 250e5bd7129d0b54594dc225f7380545189b70c1
Author: Andres Freund <andres@anarazel.de>
Date: 2016-03-07T22:24:52Z
Releases: 9.5.2
Further improvements to c8f621c43.

Coverity and inspection for the issue addressed in fd45d16f found some
questionable code.

Specifically coverity noticed that the wrong length was added in
ReorderBufferSerializeChange() - without immediate negative consequences
as the variable isn't used afterwards.  During code-review and testing I
noticed that a bit of space was wasted when allocating tuple bufs in
several places.  Thirdly, the debug memset()s in
ReorderBufferGetTupleBuf() reduce the error checking valgrind can do.

Backpatch: 9.4, like c8f621c43.

Files