Horton

Fix the handling of two GUCs during upgrade.

Amit Kapila <akapila@postgresql.org>

View on postgr.es
Commit: 24f6c1bd41d0631a04cc956cc8cafa0b117ab625
Author: Amit Kapila <akapila@postgresql.org>
Date: 2025-07-11T04:23:34Z
Releases: 17.6 
Fix the handling of two GUCs during upgrade.

Previously, the check_hook functions for max_slot_wal_keep_size and
idle_replication_slot_timeout would incorrectly raise an ERROR for values
set in postgresql.conf during upgrade, even though those values were not
actively used in the upgrade process.

To prevent logical slot invalidation during upgrade, we used to set
special values for these GUCs. Now, instead of relying on those values, we
directly prevent WAL removal and logical slot invalidation caused by
max_slot_wal_keep_size and idle_replication_slot_timeout.

Note: PostgreSQL 17 does not include the idle_replication_slot_timeout
GUC, so related changes were not backported.

BUG #18979
Reported-by: jorsol <jorsol@gmail.com>
Author: Dilip Kumar <dilipbalaut@gmail.com>
Reviewed by: vignesh C <vignesh21@gmail.com>
Reviewed by: Alvaro Herrera <alvherre@alvh.no-ip.org>
Backpatch-through: 17, where it was introduced
Discussion: https://postgr.es/m/219561.1751826409@sss.pgh.pa.us
Discussion: https://postgr.es/m/18979-a1b7fdbb7cd181c6@postgresql.org

Files

PathChange+/−
src/backend/access/transam/xlog.c modified +8 −25
src/backend/replication/slot.c modified +4 −8
src/backend/utils/misc/guc_tables.c modified +1 −1
src/bin/pg_upgrade/server.c modified +0 −11
src/include/utils/guc_hooks.h modified +0 −2

Discussion