Fix assert in logicalmsg_desc

Tomas Vondra <tomas.vondra@postgresql.org>

Commit: 239c3ee41be3b7c621c446344d09e3affeb8cd59
Author: Tomas Vondra <tomas.vondra@postgresql.org>
Date: 2022-08-16T22:17:37Z
Releases: 14.6
Fix assert in logicalmsg_desc

The assert, introduced by 9f1cf97bb5, is intended to check if the prefix
is terminated by a \0 byte, but it has two flaws. Firstly, prefix_size
includes the \0 byte, so prefix[prefix_size] points to the byte after
the null byte. Secondly, the check ensures the byte is not equal \0,
while it should be checking the opposite.

Backpatch-through: 14
Discussion: https://postgr.es/m/b99b6101-2f14-3796-3dfa-4a6cd7d4326d@enterprisedb.com

Files

PathChange+/−
src/backend/access/rmgrdesc/logicalmsgdesc.c modified +1 −1

Discussion